Properly handle frozen strings #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
fix-acl-parsing
branch
3 times, most recently
from
6c32a3d
to
f6bf772
Compare
This rewrites the ACL parsing in the type. First of all, it renames variables from a single letter to multiple so it properly describes what they are. It also fixes the octal parsing, which always resulted in rwx. More importantly, it fixes the frozen string behavior. It does this by using += instead of << and avoiding sub!. Fixes: a252009
ekohl
force-pushed
the
fix-acl-parsing
branch
from
f6bf772
to
de7b4ff
Compare
|
This is now green. I could actually reproduce once issue with frozen strings in unit tests, see the second commit. I mostly added that as a regression test before I made bigger changes and there it did show up. Still, it was very subtle and my proper fix gets rid of much more problematic code. |
bastelfreak
approved these changes
Jan 21, 2022
|
tested this locally and works fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the ACL parsing in the type.
First of all, it renames variables from a single letter to multiple so it properly describes what they are.
It also fixes the octal parsing, which always resulted in rwx.
More importantly, it fixes the frozen string behavior. It does this by using += instead of << and avoiding sub!.
Fixes: a252009